The printing function now only prints a single string, that has been created by the function PrintFrames::parseValue(vector<Frame> frames) that parses the frames

include/PrintFrames.h

@@ -2,6 +2,8 @@
 #define PRINTFRAMES_H
 
 #include <vector>
+#include <string>
+#include "../include/Frame.h"
 
 using namespace std;
 
@@ -11,8 +13,9 @@ class PrintFrames {
         
         ~PrintFrames() = default;
         
-        static void printHeader(vector<int> rolls);
+        static void printHeader();
-        static void printValue(vector<int> rolls);
+        static void printValue(string values);
+        static string parseValue(vector<Frame> frames);
 };
 
 #endif

rolls4.txt

@@ -1 +1 @@
-5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 10, 10, 10, 5, 5
+0, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 10, 10, 10, 5, 5

src/PrintFrames.cpp

@@ -1,116 +1,93 @@
 #include "../include/PrintFrames.h"
 #include <iostream>
+#include <sstream>
 
-void PrintFrames::printHeader(vector<int> rolls){
+void PrintFrames::printHeader() {
-    int frame = 0;
+    cout << "| f1 | f2 | f3 | f4 | f5 | f6 | f7 | f8 | f9 | f10   |" << endl;
-    int i = 1;
-    
-    while (true) {
-        cout << "|";
-        
-        // Strike
-        if (rolls[frame] == 10) {
-            // If we're on our last frame, and roll a strike, we're given two bonus rolls.
-            if (frame + 3 == rolls.size() && rolls[frame - 3] == 10) {
-                cout << " f" << i << "   |" << endl;
-                break;
-            }
-            
-            cout << " f" << i << " ";
-            frame += 1;
-        }
-        
-        // Spare
-        else if (rolls[frame] + rolls[frame + 1] == 10) {
-            // If we're on our last frame, and roll a spare, we're given a bonus roll.
-            if (frame + 3 == rolls.size() && rolls[frame] + rolls[frame + 1] == 10)
-            {
-                cout << " f" << i << "   |" << endl;
-                break;
-            }
-            
-            cout << " f" << i << " ";
-            frame += 2;
-        }
-        
-        // Open Frame
-        else {
-            cout << " f" << i << " ";
-            frame += 2;
-        }
-        
-        ++i;
-        
-        // No more frames
-        if (frame == rolls.size()) {
-            cout << "|" << endl;
-            break;
-        }
-    }
 }
 
-void PrintFrames::printValue(vector<int> rolls){
+void PrintFrames::printValue(string value) {
-    int frame = 0;
+    cout << value;
+}
+
+string PrintFrames::parseValue(vector<Frame> frames) {
+    string value;
+    stringstream ss;
     
-    while (true) {
+    int score = 0;
-        cout << "|";
+    
-        
+    // There can only be 10 frames.
+    for (int i = 0; i < 10; i++) {
+        ss << "|";
         // Strike
-        if (rolls[frame] == 10) {
+        if (frames[i].Roll[0] == 10) {
-            // If we're on our last frame, and roll a strike, we're given two bonus rolls.
+            if (frames[i].Roll.size() == 3) {
-            if (frame + 3 == rolls.size() && rolls[frame - 3] == 10) {
+                ss << "X, ";
-                if (rolls[frame + 1] == 10 && rolls[frame + 2] == 10) {
+                
-                    cout << "X, X, X|" << endl;
+                if (frames[i].Roll[1] == 10 && frames[i].Roll[2] == 10) {
+                    ss << "X, X";
                 }
-                else if (rolls[frame + 1] == 0 && rolls[frame + 2] == 0) {
+                else if (frames[i].Roll[1] != 10 && frames[i].Roll[2] == 10) {
-                    cout << "X, -, -|" << endl;
+                    ss << frames[i].Roll[1] << ", X  ";
                 }
-                else if (rolls[frame + 1] == 0) {
+                else if (frames[i].Roll[1] == 10 && frames[i].Roll[2] != 10) {
-                    cout << "X, -, " << rolls[frame + 2] << "|" << endl;
+                    ss << "X, " << frames[i].Roll[2] << "  ";
-                }
-                else if (rolls[frame + 2] == 0) {
-                    cout << "X, " << rolls[frame + 1] << ", -|" << endl;
-                }
-                else {
-                    cout << "X, " << rolls[frame + 1] << ", " << rolls[frame + 2] << "|" << endl;
                 }
                 
-                break;
+                continue;
             }
             
-            cout << "X   ";
+            // If the next frame has 3 or 2 rolls, then take those 2.
-            frame += 1;
+            if (frames[i + 1].Roll.size() > 1) {
+                //score += frames[i].Roll[0] + frames[i + 1].Roll[0] + frames[i + 1].Roll[1];
+                
+                if (frames[i + 1].Roll[0] == 10 && frames[i + 1].Roll[1] != 10) {
+                    ss << "X, " << frames[i + 1].Roll[0] << "  ";
+                }
+                else if (frames[i + 1].Roll[0] != 10 && frames[i + 1].Roll[1] == 10) {
+                    ss << frames[i + 1].Roll[1] << ", X";
+                } else {
+                    if (frames[i + 1].Roll[0] + frames[i + 1].Roll[1] == 10) {
+                        ss << "X, " << frames[i + 1].Roll[0] << " ,/";
+                    } else {
+                        ss << "X,  ";
+                    }
+                }
+                
+                continue;
+            }
+            
+            // Both next frames, that are not the last, are 10.
+            //score += frames[i].Roll[0] + frames[i + 1].Roll[0] + frames[i + 2].Roll[0];
+            ss << "X   ";
+            
+            continue;
         }
         
         // Spare
-        else if (rolls[frame] + rolls[frame + 1] == 10) {
+        if (frames[i].Roll[0] + frames[i].Roll[1] == 10) {
-            // If we're on our last frame, and roll a spare, we're given a bonus roll.
+            if (frames[i].Roll.size() == 3) {
-            if (frame + 3 == rolls.size() && rolls[frame] + rolls[frame + 1] == 10)
+                score += frames[i].Roll[0] + frames[i].Roll[1] + frames[i].Roll[2];
-            {
+                ss << frames[i].Roll[0] << ", /   ";
-                cout << rolls[frame] << ", /" << ", " << rolls[frame + 1] << "|" << endl;
+                continue;
-                break;
             }
             
-            cout << rolls[frame] << ", /";
+            //score += 10 + frames[i + 1].Roll[0];
-            frame += 2;
+            ss << frames[i].Roll[0] << ", /";
+            continue;
         }
         
-        // Open Frame
+        // Open frame
-        else {
+        //score += frames[i].Roll[0] + frames[i].Roll[1];
-            if (rolls[frame] == 0) {
+        if (i == 9) {
-                cout << "-" << ", " << rolls[frame + 1];
+            ss << frames[i].Roll[0] << ", " << frames[i].Roll[1] << "   ";
-            }
+        } else {
-            else if (rolls[frame + 1] == 0) {
+            ss << frames[i].Roll[0] << ", " << frames[i].Roll[1];
-                cout << rolls[frame] << ", -";
-            }
-            
-            cout << "" << rolls[frame] << ", " << rolls[frame + 1];
-            frame += 2;
-        }
-        
-        if (frame == rolls.size()) {
-            cout << " |" << endl;
-            break;
         }
     }
+    
+    ss << "|";
+    ss << endl;
+    
+    return ss.str();
 }

src/ScoreCalculator.cpp

@@ -19,7 +19,7 @@ int ScoreCalculator::getScore(vector<Frame> frames) {
                 continue;
             }
             
-            // [10] + [x] + [y]
+            // Both next frames, that are not the last, are 10.
             score += frames[i].Roll[0] + frames[i + 1].Roll[0] + frames[i + 2].Roll[0];
             continue;
         }

src/main.cpp

@@ -26,11 +26,13 @@ int main(int argc, char *argv[]) {
         return 0;
     }
     
-    PrintFrames::printHeader(rolls);
-    PrintFrames::printValue(rolls);
-    
     vector<Frame> frames = NumberHelper::createFrames(rolls);
     
+    string values = PrintFrames::parseValue(frames);
+    
+    PrintFrames::printHeader();
+    PrintFrames::printValue(values);
+    
     int score = ScoreCalculator::getScore(frames);
     cout << "Score: " << score << endl;